-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Profile page and routing #116
Conversation
Routing added added a button in navigation bar to view profile added and linked profile page In profile page username and name is being displayed by fetching it from database
I have resolved all the conflicts |
return ( | ||
<div className="app"> | ||
<BrowserRouter> | ||
<Switch> | ||
<Route exact path="/home" component={Homepage} /> | ||
<Route exact path="/home" component={Homepage}/> | ||
<Route path = "/profile" component = { Profile } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this exact
Looks good, but currently, the Profile page is mostly static. Post created by the user should be visible on his/her profile. There are a few extensions that you can do:
ps: you can pass the user's id in URL (/profile/{id}, and then fetch the details of the user on the profile page using the ID passes in URL. |
Ok, @abhishek2x
|
Hey @Aniket1103, here is some idea that might help:
|
Ok @abhishek2x, thanks for the ideas, I'll try implementing the same and will let you know once done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM..🚩
Ok, Thank you @avinashkranjan for acknowledging, |
Related Issue
Closes: #57
Describe the changes you've made
Give a clear description of what modifications you have made
Routing added
added a button in the navigation bar to view the profile,
Added and linked profile page to the button
On the profile page username and name is being displayed by fetching from the database.
Type of change
What sort of change have you made:
Mention any unusual behaviour of your code (Write NA if not)
Any unusual behaviour of your code
Checklist:
Screenshots