Issue #440 #448
Merged
Issue #440 #448
+47
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
draftcode
reviewed
Nov 6, 2024
internal/gh/ghui/push.go
Outdated
| func isDifferencePRMetadata(avbr meta.Branch, vm *GitHubPushModel) bool { | ||
| local := createPRMetadata(avbr, vm) | ||
|
|
||
| prs, err := vm.getPRs() | ||
| pr, err := vm.client.PullRequest(context.Background(), avbr.PullRequest.ID) |
There was a problem hiding this comment.
The direction looks good. Can you change the logic slightly so that we don't have to make the API call twice (once in this and another in getPRs)?
There was a problem hiding this comment.
Sorry for the delayed response. I updated
draftcode
approved these changes
Nov 20, 2024
✅ FlexReview StatusOwner: |
|
Can you rebase this to master? |
draftcode
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I used
getPRsmethod ref: (https://github.com/aviator-co/av/blob/master/internal/gh/ghui/push.go#L323)However, the method only returns push candidates branches ref: (https://github.com/aviator-co/av/blob/master/internal/gh/ghui/push.go#L325). In my understanding correct, when target branch is a push candidate branch, this logic will work well. But if the target branch is not a push candidate branch, it won't work well.
So, I updated to check PR directly.