Fix "continue validation" (list of Pattern validation etc)

[rbygrave]

Change AbstractConstraintAdapter to continue validation, Adjust NullableAdapter and NotEmptyAdapter to support existing behaviour

Note that the original failing test was for multiple @Pattern validations on the same field. The issue was that the validation would not correctly process the entire chain of validation adapters because some [like the PatternAdapter] were incorrectly returning false to stop the validation when they added a constraint violation.

The fix was a combination of changing AbstractConstraintAdapter to continue validation, plus changing NullableAdapter and NotEmptyAdapter to support existing behaviour.

[SentryMan]

Maybe I'm missing the point here, but don't all of the other existing tests imply the continuation or lack thereof? With the exception of the NotBlank and size adapter, all the adapters extend the isValid method, so continuing or not is determined by the following block.

avaje-validator/validator/src/main/java/io/avaje/validation/adapter/AbstractConstraintAdapter.java

Lines 33 to 36 in c26a2d3

	if (!isValid(value)) {
	req.addViolation(message, propertyName);
	return false;
	}

[rbygrave]

If we change AbstractConstraintAdapter + switch the assertions of the BUG expectations ... the remaining tests that break will be for the NullableAdapter and the NotEmptyAdapter [which both extend AbstractConstraintAdapter but where the expectation is for false - "not continue validation" ]

Edit: I'll add a commit to document that.

[rbygrave]

This is the PR / Change I want to go with first as it is more clear what the behaviour change / bug fix.

There are a couple of other changes in PR #269 that I'd like to see as follow up separate PRs so that we are nice and explicit about those behaviour changes.

[SentryMan]

Let's deploy an RC to unblock #266