Handle Repeatable Constraints #267
Merged
+159
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes here are not clear to me. The prisims update would address the repeatable annotation issue so it isn't clear to me what the other changes are for. Can you add comments into the diff to explain what these changes are for? |
SentryMan
commented
Jan 26, 2025
validator-generator/src/main/java/io/avaje/validation/generator/ElementAnnotationContainer.java
Show resolved
Hide resolved
SentryMan
commented
Jan 26, 2025
validator-generator/src/main/java/io/avaje/validation/generator/ElementAnnotationContainer.java
Show resolved
Hide resolved
rbygrave
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now can properly read repeatable container annotations.
Resolves #266
Relies on: avaje/avaje-prisms#95