Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com4]: Select raster computation depending on output files #1075

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[com4]: Select raster computation depending on output files #1075

wants to merge 4 commits into from

Conversation

PaulaSp3
Copy link
Contributor

  • take the arguments of function calculation() into dictionaries
  • only compute the numpy arrays that should be output rasters
  • only execute otherwise unneccessary cell - methods (calc_fp_travelangle() and calc_fp_travelangle()) when needed (when the respective outputs are required) (save ~10% of the computation time when fpTravelAngle, sl_TravelAngle and travelLength are not in the outputList
  • think of also simplify the argument for the class Cell using dictionaries -> issue [com4FlowPy]: minor improvements #1062

@PaulaSp3 PaulaSp3 added enhancement New feature or request flowPyDev Ideas for future development labels Jan 23, 2025
@PaulaSp3 PaulaSp3 requested a review from ahuber-bfw January 23, 2025 15:11
@PaulaSp3 PaulaSp3 linked an issue Jan 23, 2025 that may be closed by this pull request
[com4FlowPy]: Selective calculation of Model Output Rasters #1064
Open
1 task
@pep8speaks
Copy link

pep8speaks commented Jan 23, 2025 •
edited
Loading

Hello @PaulaSp3! Thanks for updating this PR.

Line 623:13: E265 block comment should start with '# '
Line 622:13: E265 block comment should start with '# '
Line 571:121: E501 line too long (121 > 120 characters)
Line 343:121: E501 line too long (121 > 120 characters)

Line 556:11: E127 continuation line over-indented for visual indent
Line 497:121: E501 line too long (128 > 120 characters)

Comment last updated at 2025-01-23 15:17:04 UTC

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 23, 2025

Code Climate has analyzed commit e1979b5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.0%.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahuber-bfw ahuber-bfw Awaiting requested review from ahuber-bfw

At least 1 approving review is required to merge this pull request.

Assignees

@PaulaSp3 PaulaSp3

@ahuber-bfw ahuber-bfw

Labels
enhancement New feature or request flowPyDev Ideas for future development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[com4FlowPy]: Selective calculation of Model Output Rasters
3 participants
@PaulaSp3 @pep8speaks @ahuber-bfw