Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com4FlowPy]: Selective calculation of Model Output Rasters #1064

Open
1 task
ahuber-bfw opened this issue Jan 14, 2025 · 3 comments · May be fixed by #1075
Open
1 task

[com4FlowPy]: Selective calculation of Model Output Rasters #1064

ahuber-bfw opened this issue Jan 14, 2025 · 3 comments · May be fixed by #1075
Assignees
Labels
enhancement New feature or request flowPyDev Ideas for future development

Comments

@ahuber-bfw
Copy link
Contributor

We now have the outputFiles option in [PATHS] in the (local_)com4FlowPyCfg.ini, but up to now only use it in com4FlowPy.py -> mergeAndWriteResults() to select which result-Rasters are finally written to disk as .tif or .asc files.

However, regardless of the options provided in outputFiles we still do all the calculations for all possible result rasters (i.e. we calculate routFluxSum, depFluxSum and everything else, even if we don't write it to disk later).

  • Potentially we can save some CPU-time/RAM/HD-Space by only initializing and calculating the result arrays, that are specified in [PATHS] 'outputFiles' option -- e.g. by passing the option to calculation() and return None for all the arrays, that are not specified in the .ini

This will be increasingly important (1) if we plan to introduce additional output rasters in the future and (2) for any regional scale application

@ahuber-bfw ahuber-bfw added enhancement New feature or request flowPyDev Ideas for future development labels Jan 14, 2025
@ahuber-bfw
Copy link
Contributor Author

moved this point from issue #1062 to this separate issue

@PaulaSp3
Copy link
Contributor

in flowCore.py in the function run() the part where the outputs are computed and saved does need much CPU-time (when the simulation needs 58 s, this part needs 0.2 s), so with a modification we can't save CPU-time significantly

@PaulaSp3
Copy link
Contributor

we could think about selecting the methods of a cell that are executed depending on the output rasters (e.g. the execution of calc_fp_travelangle is only necessary for the raster fp_travelAngle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flowPyDev Ideas for future development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants