implement ReadLinearStore for Historical
#632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 11, 2024 21:24
added 8 commits
April 12, 2024 16:37
danlaine
requested review from
xinifinity,
rkuris and
richardpringle
as code owners
rkuris
approved these changes
Apr 17, 2024
added 3 commits
April 18, 2024 13:44
…irewood into danlaine/implement-historical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type
Layerand uses it inLayeredReader. This generalizesLayeredReaderso that it's logic is basically, "if the index I'm looking for is in the diff, use that. Otherwise use the parent."For a
Historical, the diff is all the values written in the next revision. i.e. to read from aHistorical, read from its parent, unless the index we're reading was overwritten in the parent. Note that the parent is the revision after this one.For a
Proposed, the diff is all the values written in the proposal. i.e. to read from aProposed, read from its parent, unless the index we're reading was overwritten in theProposed. Note the parent is the revision before this one.Uses
LayeredReaderto implementHistorical::stream_from.Adds a
sizefield toHistoricalto implementHistorical::size. This seems the most straightforward way to do this. When we're creating theHistorical, we know how big it is, so might as well just hold onto that information.