CP-9925: Interactive Chart in Track Token Detail #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onghwan
requested review from
neven-s,
atn4z7,
ruijialin-avalabs and
bogdandobritoiu
as code owners
onghwan
commented
Feb 28, 2025
There was a problem hiding this comment.
To deprecate the useApp() hook, I extracted two currency format functions and turned them into a separate hook.
onghwan
commented
Feb 28, 2025
| + [circleX, isActive, pathEnd, pathRange.x, width] | ||
| ) | ||
|
|
||
| const setIsActive = useCallback( |
There was a problem hiding this comment.
In the previous graph, tracking the y-value of the finger’s position on the graph wasn’t necessary. However, in the graph within the new design, it is needed, so I modified the patch accordingly.
packages/core-mobile/app/new/routes/(signedIn)/(modals)/trackTokenDetail/index.tsx
Show resolved
Hide resolved
onghwan
commented
Feb 28, 2025
| </Text> | ||
| <Text variant="heading2"> | ||
| {formatTokenInCurrency(selectedData?.value ?? 0)} | ||
| </Text> |
There was a problem hiding this comment.
we can try the AnimatedText here later after resolving some performance issues. It was very laggy when I used it.
| <Text | ||
| variant="subtitle2" | ||
| sx={{ | ||
| color: percentChange < 0 ? '$textDanger' : '$textSuccess' |
There was a problem hiding this comment.
should we show neutral color for 0?
| </View> | ||
| <View sx={{ opacity: priceChange ? 1 : 0 }}> | ||
| <PriceChangeIndicator | ||
| formattedPrice={priceChange?.formattedPrice ?? '$0.00'} |
There was a problem hiding this comment.
should we keep the idea of using UNKNOWN_AMOUNT when there is no price?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9925
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-28.at.09.35.34.mp4