CP-9963 - [Component] AnimatedPressable #2324
Merged
+175
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandobritoiu
requested review from
neven-s,
atn4z7,
ruijialin-avalabs and
onghwan
as code owners
| onPressIn={onPressIn} | ||
| onPressOut={onPressOut} | ||
| {...props} | ||
| style={[animatedStyle, props.style]}> |
There was a problem hiding this comment.
can we order like this? [props.style, animatedStyle]. I don't think we want the opacity and transform to be overridden by mistake.
There was a problem hiding this comment.
Yes, correct.
| const opacity = useSharedValue(0) | ||
| const scale = useSharedValue(0.8) | ||
| export const AnimateFadeScale = memo( | ||
| ({ children, delay = 0 }: { children: JSX.Element; delay?: number }) => { |
There was a problem hiding this comment.
does it not give you warning about the missing return type?
There was a problem hiding this comment.
It doesn't show any warning. On hover it does show that the component returns a React.JSX.Element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9963
Component will be reused for animating cards/buttons/boxes.
Functionality:
Screenshots/Videos
Screen.Recording.2025-02-26.at.20.24.02.mov
Testing
Not much to test, component will be reused on most animations for cards/texts
Checklist
Please check all that apply (if applicable)