CP-9935: Portfolio Tab Navigation #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onghwan
requested review from
neven-s,
atn4z7 and
ruijialin-avalabs
as code owners
atn4z7
reviewed
Feb 17, 2025
Comment on lines
187
to
193
| <AssetsScreen onScroll={onScroll} /> | ||
| </Tabs.Tab> | ||
| <Tabs.Tab name="Collectibles"> | ||
| <CollectiblesScreen onScroll={onScroll} /> | ||
| </Tabs.Tab> | ||
| <Tabs.Tab name="DeFi"> | ||
| <DeFiScreen onScroll={onScroll} /> |
There was a problem hiding this comment.
could we create a wrapper component that contains the onScroll logic so that actual screens (AssetsScreen,...) don't need to include that logic?
There was a problem hiding this comment.
good point. fixed. d2b3a00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9935
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-02-17.at.14.49.13.mp4
Screen.Recording.2025-02-17.at.2.52.10.PM.mov
Notes
react-native-pager-view, which does not allow content to overflow. As a result,. the blur effect cannot be applied to the header and bottom tab bar. We'll address this in a separate ticket.