Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use get over getSecurityKey to authenticate passkey #2200

Merged
merged 2 commits into from
Jan 27, 2025
Merged

use get over getSecurityKey to authenticate passkey #2200

merged 2 commits into from
Jan 27, 2025

Conversation

ruijialin-avalabs
Copy link
Contributor

Description

  • update getCredential to use get() instead of getSecurityKey() to avoid iOS prompt only for security key.

Testing

  • tested on both android and iOS with getCrentials(), and they are both working.

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@ruijialin-avalabs
use get over getSecurityKey to authenticate passkey

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
dbc9954
atn4z7
atn4z7 previously approved these changes Jan 27, 2025
View reviewed changes
@ruijialin-avalabs ruijialin-avalabs merged commit f051082 into main Jan 27, 2025
4 checks passed
@ruijialin-avalabs ruijialin-avalabs deleted the fixIosPasskeyAuthenticate branch January 27, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atn4z7 atn4z7

@neven-s neven-s

@onghwan onghwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruijialin-avalabs @atn4z7