Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): mount autoware_data in container #5831

Merged

Conversation

amadeuszsz
Copy link
Contributor

@amadeuszsz amadeuszsz commented Feb 28, 2025

Description

Docker containers without ML artifacts requires data directory. This change is an effect of ML artifacts removal from our images addressed in #5830.

How was this PR tested?

Notes for reviewers

Effects on system behavior

None.

Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
Copy link

github-actions bot commented Feb 28, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@amadeuszsz amadeuszsz self-assigned this Feb 28, 2025
@amadeuszsz amadeuszsz added the type:containers Docker containers, containerization of components, or container orchestration. label Feb 28, 2025
@youtalk
Copy link
Member

youtalk commented Mar 6, 2025

Since #5830 was merged, please ready for review this PR.

@amadeuszsz amadeuszsz marked this pull request as ready for review March 6, 2025 06:38
@amadeuszsz amadeuszsz added the tag:run-health-check Run health-check label Mar 6, 2025
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit e6d8120 into autowarefoundation:main Mar 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants