Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hover tooltips for typescript #49

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Update hover tooltips for typescript #49

merged 7 commits into from
Jun 27, 2023

Conversation

flenter
Copy link
Member

@flenter flenter commented Jun 15, 2023

By adding a HoverProvider and updating the bundled @autometrics/typescript-plugin so it creates special "hover" information as an html-comment which in turn can be parsed by the extension.

This requires autometrics-dev/autometrics-ts#72 to be merged in and released.

TODO before release:

  • update @autometrics/typescript-plugin dependency

If people want to test this locally, they need to:

  • clone the autometrics-dev/autometrics-ts repo
  • checkout the html-comment branch
  • run npm install and npm run build
  • install it via a relative path (i.e. yarn add "../autometrics-ts/packages/typescript-plugin")

Copy link
Member

@laulauland laulauland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?.*approved

@flenter flenter marked this pull request as ready for review June 27, 2023 11:52
@flenter flenter merged commit 23b769a into main Jun 27, 2023
@flenter flenter deleted the toggle_html branch June 27, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants