Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for only passing in the port for a metric endpoint #26

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Add support for only passing in the port for a metric endpoint #26

merged 2 commits into from
Jun 14, 2023

Conversation

hatchan
Copy link
Contributor

@hatchan hatchan commented Jun 13, 2023

  • Add support for only passing in the port for a metric endpoint
  • Verify that the url is either http or https

mellowagain
mellowagain approved these changes Jun 14, 2023
View reviewed changes
@hatchan hatchan merged commit 0be5ed8 into main Jun 14, 2023
@hatchan hatchan deleted the just_a_port branch June 14, 2023 09:43
@hatchan hatchan mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mies mies mies approved these changes

@mellowagain mellowagain mellowagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hatchan @mies @mellowagain