Decouple validation file schema compilation from yaml parsing #2268
+78
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
tstirrat15
force-pushed
the
OSS-214/decouple-validation-parsing-from-schema-parsing
branch
from
32c1035 to
fb0590d
Compare
tstirrat15
force-pushed
the
OSS-214/decouple-validation-parsing-from-schema-parsing
branch
3 times, most recently
from
5bb9cc2 to
6426b2f
Compare
tstirrat15
force-pushed
the
OSS-214/decouple-validation-parsing-from-schema-parsing
branch
from
6426b2f to
340335e
Compare
tstirrat15
commented
Mar 10, 2025
| @@ -37,10 +37,10 @@ linters: | |||
| - 'rowserrcheck' | |||
| - 'staticcheck' | |||
| - 'stylecheck' | |||
| - 'tenv' | |||
There was a problem hiding this comment.
This was marked as deprecated in favor of usetesting when I ran golangci-lint run locally.
| @@ -46,8 +46,7 @@ func TestCertRotation(t *testing.T) { | |||
| waitFactor = 2 | |||
| ) | |||
|
|
|||
| certDir, err := os.MkdirTemp("", "test-certs-") | |||
| require.NoError(t, err) | |||
| certDir := t.TempDir() | |||
There was a problem hiding this comment.
one of the lint recommendations.
| // Schema is the schema found. | ||
| Schema string | ||
|
|
||
| // SourcePosition is the position of the schema in the file. | ||
| SourcePosition spiceerrors.SourcePosition | ||
|
|
||
| // CompiledSchema is the compiled schema. | ||
| CompiledSchema *compiler.CompiledSchema |
There was a problem hiding this comment.
This got pushed out into CompileSchema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of making it possible to run
zed validateon files that use composable schema syntax. In order to have different compilation behaviors in different cases, we need to not run the compilation as a part of yaml parsing. This implements that.Changes
Will annotate.
Testing
Review. See that things are green.