Update the datastore interface to return the number of deleted relationships #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
deleted-rel-count
branch
2 times, most recently
from
d1c65ab to
b1eda0f
Compare
vroldanbet
reviewed
Mar 10, 2025
| @@ -391,7 +391,7 @@ func (rwt spannerReadWriteTXN) DeleteNamespaces(ctx context.Context, nsNames ... | |||
| // Ensure the namespace exists. | |||
|
|
|||
| relFilter := &v1.RelationshipFilter{ResourceType: nsName} | |||
| if _, err := deleteWithFilter(ctx, rwt.spannerRWT, relFilter); err != nil { | |||
| if _, _, err := deleteWithFilter(ctx, rwt.spannerRWT, relFilter); err != nil { | |||
There was a problem hiding this comment.
hmm, are we dropping relationships if a namespace is deleted? Isn't that supposed to be an error?
There was a problem hiding this comment.
No; this has been a long-standing internal thing we've done. We still verify you cannot do so, but it is at the API layer, so this operation usually no-ops
pkg/datastore/datastore.go
Outdated
| @@ -504,11 +504,12 @@ type ReadWriteTransaction interface { | |||
| WriteRelationships(ctx context.Context, mutations []tuple.RelationshipUpdate) error | |||
|
|
|||
| // DeleteRelationships deletes relationships that match the provided filter, with | |||
| // the optional limit. If a limit is provided and reached, the method will return | |||
| // true as the first return value. Otherwise, the boolean can be ignored. | |||
| // the optional limit. Returnds the number of deleted relationships. If a limit | |||
There was a problem hiding this comment.
Suggested change
| // the optional limit. Returnds the number of deleted relationships. If a limit | |
| // the optional limit. Returns the number of deleted relationships. If a limit |
josephschorr
force-pushed
the
deleted-rel-count
branch
from
b1eda0f to
2ebd0d4
Compare
vroldanbet
approved these changes
Mar 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be added to the API in a followup