Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix buf push tag on release #96

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix buf push tag on release #96

merged 1 commit into from
Mar 19, 2024

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Mar 19, 2024

the buf github action does not support
configuring the tag to be pushed, so it
always defaults to pushing the github SHA.

This changes the action to push the tag
to BSR with the ref_name instead of the commit
SHA.

see https://github.com/authzed/api/actions/runs/8331581711/job/22798794304

Also see bufbuild/buf-push-action#20 (comment) for future changes on this topic, the buf team will be introducing some changes to help here

the buf github action does not support
configuring the tag to be pushed, so it
always defaults to pushing the github SHA.

This changes the action to push the tag
to BSR with the ref_name instead of the commit
SHA.
@vroldanbet vroldanbet force-pushed the push-github-tag-as-buf-tag branch from a7ba0b5 to 792264b Compare March 19, 2024 08:15
@vroldanbet vroldanbet requested a review from josephschorr March 19, 2024 08:18
@vroldanbet vroldanbet self-assigned this Mar 19, 2024
@vroldanbet vroldanbet merged commit 895d1dd into main Mar 19, 2024
3 checks passed
@vroldanbet vroldanbet deleted the push-github-tag-as-buf-tag branch March 19, 2024 09:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants