Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk export to the experimental service #63

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

jakedt
Copy link
Member

@jakedt jakedt commented May 17, 2023

No description provided.

@jakedt
Copy link
Member Author

jakedt commented May 17, 2023

The implementation: authzed/spicedb#1326

// BulkExportRelationships is the fastest path available to exporting
// relationships from the server. It is resumable, and will return results
// in an order determined by the server.
rpc BulkExportRelationships(BulkExportRelationshipsRequest)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpick here is that there's no duality with the other bulk command. It should either be Load/Save or Import/Export

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

jzelinskie
jzelinskie previously approved these changes May 18, 2023
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakedt jakedt merged commit 125e39e into main May 18, 2023
@jakedt jakedt deleted the bulk-export-experimental branch May 18, 2023 17:56
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants