Add support for limits and partial operation to DeleteRelationships #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
deletion-limits
branch
2 times, most recently
from
2dcba2b to
180c4be
Compare
jzelinskie
reviewed
May 8, 2023
| // deleted_at is the revision at which the relationships were deleted. | ||
| ZedToken deleted_at = 1; | ||
|
|
||
| // result is the result of the deletion. |
There was a problem hiding this comment.
Result is an enumeration of the possible outcomes that occurred when attempting to delete the specified relationships.
jzelinskie
reviewed
May 8, 2023
| // RESULT_PARTIAL_MATCHING_DELETED indicates that a subset of the relationships matching the filter | ||
| // were deleted. Only returned if optional_allow_partial_deletions was true, an optional_limit was | ||
| // specified, and there existed more relationships matching the filter than optional_limit would allow. | ||
| DELETION_RESULT_PARTIAL_MATCHING_DELETED = 2; |
There was a problem hiding this comment.
If I allow partial deletions am I supposed to spin in a loop until I finally get DELETION_RESULT_ALL_MATCHING_DELETED?
vroldanbet
reviewed
May 9, 2023
vroldanbet
previously approved these changes
May 9, 2023
josephschorr
force-pushed
the
deletion-limits
branch
from
180c4be to
97b1983
Compare
vroldanbet
previously approved these changes
May 9, 2023
josephschorr
force-pushed
the
deletion-limits
branch
from
97b1983 to
8f33ddb
Compare
jzelinskie
approved these changes
May 9, 2023
vroldanbet
approved these changes
May 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.