Add support for cursors to LookupResources #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
reviewed
May 1, 2023
| @@ -76,6 +76,15 @@ message ZedToken { | |||
| } ]; | |||
| } | |||
|
|
|||
| // Cursor is used to provide resumption of listing between calls to APIs | |||
| // such as LookupResources. | |||
| message Cursor { | |||
There was a problem hiding this comment.
Do we need a message for this or should we just use a string field in the parent message?
There was a problem hiding this comment.
I like having a message in case we need to make semantics changes to it, like we do for ZedToken
There was a problem hiding this comment.
I guess that's fine since clients will just copying this whole message at a time if they need it.
If they maybe wanted to save it in a db or something, it could help to already just be a string.
There was a problem hiding this comment.
Yeah, that's the idea
jakedt
requested changes
May 1, 2023
| // before the stream is closed on the server side. By default, the stream will continue | ||
| // resolving resources until exhausted or the stream is closed due to the client or a | ||
| // network issue. | ||
| uint32 optional_limit = 6; |
|
Updated |
jakedt
requested changes
May 2, 2023
vroldanbet
approved these changes
May 2, 2023
jakedt
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remains backwards compatible because the new fields are optional on the request