introduce caveat context in PermissionService #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
reviewed
Oct 6, 2022
vroldanbet
force-pushed
the
add-caveat-context-to-permission-service
branch
from
3f47eb1 to
008d221
Compare
josephschorr
reviewed
Oct 6, 2022
vroldanbet
force-pushed
the
add-caveat-context-to-permission-service
branch
3 times, most recently
from
3d87dec to
4df875a
Compare
vroldanbet
force-pushed
the
add-caveat-context-to-permission-service
branch
from
4df875a to
c962285
Compare
josephschorr
reviewed
Oct 7, 2022
.github/workflows/lint.yaml
Outdated
| @@ -4,10 +4,9 @@ on: | |||
| push: | |||
| branches: | |||
| - "!dependabot/*" | |||
| - "*" | |||
| - "main" | |||
There was a problem hiding this comment.
So we don't get duplicated CI builds running in a PR. It's the same pattern we use in other repos.
There was a problem hiding this comment.
Can you put that as a distinct commit then and explain that in the message?
There was a problem hiding this comment.
addressed in 1a3254e
There was a problem hiding this comment.
Ideally, development would be done on a fork and this value should be * so that if we were to produce a v2 branch etc... it would run CI correctly.
this makes it possible for clients to provide context for caveat evaluation at request time. This context will be injected at evaluation time and influence the evaluation result.
vroldanbet
force-pushed
the
add-caveat-context-to-permission-service
branch
from
c962285 to
5b454a7
Compare
jzelinskie
reviewed
Oct 13, 2022
vroldanbet
force-pushed
the
add-caveat-context-to-permission-service
branch
from
1a3254e to
5b454a7
Compare
jzelinskie
approved these changes
Oct 14, 2022
josephschorr
approved these changes
Oct 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of authzed/spicedb#881
Part of authzed/spicedb#882
Part of authzed/spicedb#880
this makes it possible for clients to provide context for caveat evaluation at request time.
This context will be injected at evaluation time and influence the evaluation result.