v1: update permission services docstrings #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
reviewed
May 6, 2022
| // with an optional set of precondition relationships that must exist before | ||
| // the operation can commit. | ||
| // WriteRelationships atomically writes and/or deletes a set of specified | ||
| // relationships with an optional set of precondition relationships that |
| // the operation can commit. | ||
| // WriteRelationships atomically writes and/or deletes a set of specified | ||
| // relationships with an optional set of precondition relationships that | ||
| // must be satisfied before the operation can commit. |
There was a problem hiding this comment.
for the operation to commit
| // DeleteRelationships deletes relationships matching one or more filters, in | ||
| // bulk. | ||
| // DeleteRelationships atomically bulk deletes relationships matching one or | ||
| // more filters with an optional set of preconditions that must be satisfied |
| @@ -43,8 +44,8 @@ service PermissionsService { | |||
| }; | |||
| } | |||
|
|
|||
| // CheckPermission checks whether a subject has a particular permission or is | |||
| // a member of a particular relation, on a given resource. | |||
| // CheckPermission determines for a given reason whether a subject computes | |||
| // CheckPermission checks whether a subject has a particular permission or is | ||
| // a member of a particular relation, on a given resource. | ||
| // CheckPermission determines for a given reason whether a subject computes | ||
| // to having permission or is a direct member of a particular relation. |
This clarifies the atomicity of WriteRelationships and runs the other comments through a grammar check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the atomicity of WriteRelationships and runs the other comments through a grammar check.