Skip to content

modify watchResponse #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions authzed/api/v1/watch_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

import "authzed/api/v1/core.proto";
import "authzed/api/v1/permission_service.proto";
import "authzed/api/v1/schema_service.proto";

service WatchService {
rpc Watch(WatchRequest) returns (stream WatchResponse) {
Expand Down Expand Up @@ -60,7 +59,7 @@
// If specified, optional_object_types cannot be used.
repeated RelationshipFilter optional_relationship_filters = 3;

// optional_update_kinds, if specified, indicates what kinds of mutations to include
// optional_update_kinds, if specified, indicates what kinds of mutations to include.
repeated WatchKind optional_update_kinds = 4;
}

Expand All @@ -83,10 +82,11 @@
// This field may not exist if no transaction metadata was provided.
google.protobuf.Struct optional_transaction_metadata = 3;

// schema_updates are the schema update events that have occurred since the
// last watch response.
repeated ReflectionSchemaDiff schema_updates = 4;
// schema_updated, if true, indicates that the schema was changed in this revision.
bool schema_updated = 4;

Check failure on line 86 in authzed/api/v1/watch_service.proto

View workflow job for this annotation

GitHub Actions / Lint & Publish Draft/Branch

Field "4" with name "schema_updated" on message "WatchResponse" changed option "json_name" from "schemaUpdates" to "schemaUpdated".

Check failure on line 86 in authzed/api/v1/watch_service.proto

View workflow job for this annotation

GitHub Actions / Lint & Publish Draft/Branch

Field "4" on message "WatchResponse" changed label from "repeated" to "optional".

Check failure on line 86 in authzed/api/v1/watch_service.proto

View workflow job for this annotation

GitHub Actions / Lint & Publish Draft/Branch

Field "4" on message "WatchResponse" changed type from "message" to "bool". See https://developers.google.com/protocol-buffers/docs/proto3#updating for wire compatibility rules and https://developers.google.com/protocol-buffers/docs/proto3#json for JSON compatibility rules.

Check failure on line 86 in authzed/api/v1/watch_service.proto

View workflow job for this annotation

GitHub Actions / Lint & Publish Draft/Branch

Field "4" on message "WatchResponse" changed name from "schema_updates" to "schema_updated".

// is_checkpoint, if true, indicates that a revision was reached.
// is_checkpoint, if true, indicates that a checkpoint was reached.
// A checkpoint indicates that the server guarantees that the client
// will not observe any changes at a revision below or equal to the revision in this response.
bool is_checkpoint = 5;
}
Loading