added generic get/set metadata methods on UserBase #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
requested changes
Aug 17, 2023
- extended get/set metadata tests
frederikprijck
requested changes
Aug 21, 2023
|
I removed the incorrect exception documentation |
frederikprijck
force-pushed
the
feat/generic-get-user-metadata
branch
from
47e6121 to
94921fc
Compare
frederikprijck
force-pushed
the
feat/generic-get-user-metadata
branch
from
94921fc to
bbd9cf3
Compare
frederikprijck
approved these changes
Aug 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added generic methods to get/set user metadata, e.g.:
userInstance.getAppMetadata<MyAppMetadata>();userInstance.getUserMetadata<MyUserMetadata>();userInstance.setAppMetadata(myAppMetadata);userInstance.setUserMetadata(myUserMetadata);As for now Newtonsoft.Json.Linq.JObject is used as this type seems to be deserialized when reading users.
Auth0.ManagementApi.Models.UserBase
Auth0.ManagementApi.IntegrationTests.UsersTests:
References
#645
Testing
Retrieve a user with AppMetadata, call getAppMetadata with a matching type and see the filled properties
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
I'm unable to run the tests as configuration seems missing
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors
I'm unable to run the tests as configuration seems missing