Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cancellation token to device credentials request #619

Conversation

msmolka
Copy link
Contributor

@msmolka msmolka commented May 19, 2023

Changes

Please describe both what is changing and why this is important. Include:

  • Endpoints changed
    • get device credentials
  • Classes and methods changed
  • DeviceCredentialsClient.GetAllAsync
  • A summary of usage if this is a new feature or change to a public API (this should also be added to relevant documentation once released)
    • allow cancel request of get device credentials endpoint. Added support for cancellation token.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@msmolka msmolka requested a review from a team as a code owner May 19, 2023 09:39
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frederikprijck frederikprijck merged commit 21c3621 into auth0:master May 22, 2023
@frederikprijck frederikprijck mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants