Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passwordlessVerify not sending nonce #489

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Conversation

luisrudge
Copy link
Contributor

No description provided.

@luisrudge luisrudge modified the milestones: v8-Next, v8.9.2 Aug 17, 2017
lbalmaceda
lbalmaceda previously approved these changes Aug 17, 2017
expect(mockVerify.firstCall.args[0]).to.be.eql(expectedOptions);
});
it('should call callback with error', function(done) {
var expectederror = new Error('some error');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase this var

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it 🚀

@luisrudge luisrudge merged commit 4f7a23b into master Aug 17, 2017
@luisrudge luisrudge deleted the fix-pwdless-nonce branch August 17, 2017 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants