Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup.authorize should not require redirectURI when using OWP #336

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

glena
Copy link
Contributor

@glena glena commented Jan 30, 2017

No description provided.

@glena glena force-pushed the fix-redirecturi-popup branch from 7c34a7c to 7edb3f9 Compare January 30, 2017 13:25
@codecov-io
Copy link

codecov-io commented Jan 30, 2017

Codecov Report

Merging #336 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   98.82%   98.82%   +<.01%     
==========================================
  Files          30       30              
  Lines        1023     1024       +1     
  Branches      167      167              
==========================================
+ Hits         1011     1012       +1     
  Misses         12       12
Impacted Files Coverage Δ
src/authentication/index.js 100% <ø> (ø)
src/web-auth/popup.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c98ce0...9416847. Read the comment docs.

@glena glena force-pushed the fix-redirecturi-popup branch from 7edb3f9 to 9416847 Compare January 30, 2017 18:22
@hzalaz hzalaz added this to the v8-Next milestone Jan 30, 2017
@hzalaz hzalaz merged commit bbc6e50 into master Jan 30, 2017
@hzalaz hzalaz deleted the fix-redirecturi-popup branch January 30, 2017 18:34
@glena glena modified the milestones: v8-Next, v8.2.0 Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants