Support a guard without calling createAuthGuard #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
force-pushed
the
fix/guard-app
branch
from
8d315ce to
a2d16ff
Compare
frederikprijck
added
CH: Added
|
The Browserstack job doesn't seem to be running properly. If you look on CircleCI, the job is there but doesn't seem to run nor can you click through to it to see details. |
stevehobbsdev
approved these changes
Mar 1, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the possibility to use a Guard without having to call
createAuthGuard. This requires the exposure of our API through an exported object, as we have no access to the Vue App orinject.The consequence here is that it won't work with multiple Vue applications on a single page, assuming they are using a different Domain and/or Client ID.
References
#73
Testing
Checklist