Gracefully handle errors upon plugin installation #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
changed the title
stevehobbsdev
approved these changes
Apr 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
__checkSession is a private method that is only called when the plugin is being installed.
We should ensure errors are not thrown as that would fail running the application and installing the plugin.
Instead, errors are available using the
errorsproperty on the plugin.On top of that, we added the possibility to provide an errorPath to control where the SDK should redirect to when an error occured. If omitted, our SDK will redirect back to
/when an error occured.References
Closes #223
Testing
Checklist