Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jira SYS-29] Move _post hook to _postCommit. Civix upgrade. #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Jira SYS-29] Move _post hook to _postCommit. Civix upgrade. #4

wants to merge 2 commits into from

Conversation

andrew-cormick-dockery
Copy link
Contributor

I have tested this in my local dev by doing the following:

  1. Logging into the NSW domain
  2. Ensuring local dev SMTP settings are configured for the local dev domain
  3. Creating a new event using a NSW template (expect: Email received. Result: Received two emails)
  4. Copied an existing NSW event (expect: Email received. Result: Received two emails)

I might have to check to see if the doubling of the emails is a regression.

@andrew-cormick-dockery
Copy link
Contributor Author

OK, so I restored the previous version of this extension, deleted the contents of the templates_c directory completely, performed a drush cr, then tried to copy an event again. I still got two emails. So it's a bug, but not caused by this PR as far as I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johntwyman johntwyman johntwyman approved these changes

Assignees

@Loreith Loreith

@seamuslee001 seamuslee001

@johntwyman johntwyman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-cormick-dockery @johntwyman @Loreith @seamuslee001