Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.lock #336

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Update Cargo.lock #336

merged 1 commit into from
Apr 23, 2022

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Apr 23, 2022

Hello!

I saw that manifest files of the crates are updated in 22a7d88 but the versions in Cargo.lock are not updated.

I spotted this issue while building the Arch Linux package:

$ cargo build --locked
error: the lock file /build/atuin/src/atuin-0.9.0/Cargo.lock needs to be updated but --locked was passed to prevent this

--locked flag is required for the reproducibility of the package. Read more about it here.

This PR updates Cargo.lock for matching the versions in Cargo.toml. (i.e. I simply ran cargo build once for updating the lock file.)

P.S. Congrats on the new release! I see that you've added some nice features. I'm curious about the reason behind switching to axum 🐻

@ellie
Copy link
Member

ellie commented Apr 23, 2022

Ohh yikes, nice catch - thank you! Can't believe I missed that 🤦‍♀️

@conradludgate
Copy link
Collaborator

Oh hey, while you're here. Could you add --all-features to the pkgbuild? We have added them as defaults for now, but are considering disabling some in future. Obviously we don't want to break any existing arch user installs

@ellie ellie enabled auto-merge (squash) April 23, 2022 20:18
@conradludgate
Copy link
Collaborator

As for the reason why we switched to axum, mostly for a more ergonomic and less magic API, while still being as performant and secure as warp (running on hyper). It also reduces compile times due to reduced monomorphisation requirements

@ellie ellie merged commit 8737474 into atuinsh:main Apr 23, 2022
@orhun
Copy link
Contributor Author

orhun commented Apr 23, 2022

Oh hey, while you're here. Could you add --all-features to the pkgbuild? We have added them as defaults for now, but are considering disabling some in future. Obviously we don't want to break any existing arch user installs

Sure, I think it is related to #328. Thanks for letting me know! 🐻

As for the reason why we switched to axum, mostly for a more ergonomic and less magic API, while still being as performant and secure as warp (running on hyper). It also reduces compile times due to reduced monomorphisation requirements

Interesting, I'm going to give it a try when I have the opportunity for sure.

ellie added a commit that referenced this pull request Apr 23, 2022
a050faa Use `--locked` flag for CI builds (#337)
8737474 Update Cargo.lock (#336)
eab1dbf sql builder (#333)

Fixed to include an updated lockfile that was missed in the last release

Thank you for the rapid report @orhun!
@ellie ellie mentioned this pull request Apr 23, 2022
ellie added a commit that referenced this pull request Apr 23, 2022
a050faa Use `--locked` flag for CI builds (#337)
8737474 Update Cargo.lock (#336)
eab1dbf sql builder (#333)

Fixed to include an updated lockfile that was missed in the last release

Thank you for the rapid report @orhun!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants