Fix SQL cache query #318
Merged
Fix SQL cache query #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just deployed the older version and it was falling back on the full count. Turns out this is because it won't upcast from INT4 to INT8 automatically, and it has to be manual At some point the underlying total should be changed to int8, but also I highly doubt anyone will have enough shell history to fill an int4 lol
conradludgate
approved these changes
Apr 21, 2022
yes exactly 😂
I hope this isn't quoted in an incident report in like 20 years time 😂 |
ellie
added a commit
that referenced
this pull request
Apr 23, 2022
89549b3 Bump uuid from 0.8.2 to 1.0.0 (#311) 831cc98 Fix typos in the docs. (#171) 7436e4f feature-flags (#328) 508d4f4 History filter (#329) 02c70de refactor (#327) a9d1ece Added docker-compose.yml (#325) b8bdd83 Bump clap from 3.1.10 to 3.1.11 (#323) 52a3d0c Bump tracing from 0.1.33 to 0.1.34 (#324) 79597b0 Bump clap_complete from 3.1.1 to 3.1.2 (#316) 5aca611 Allow for larger commands (#321) 9085485 tracing (#315) 98d70fb treat popos as ubuntu (#319) d57f549 refactor commands for better separation (#313) 24e2971 Fix SQL cache query (#318) fe05d86 Fix delete trigger (#317) 48747e3 A few minor tweaks (#314) ed4e07d Use the count cache (#312) 6e11b8e Bump clap from 3.1.9 to 3.1.10 (#309) 44e417d Bump axum from 0.5.1 to 0.5.3 (#310) b98a378 Add count trigger (#308) 7fe523a Bump sqlx from 0.5.11 to 0.5.13 (#305) c5ab2a4 Bump clap from 3.1.8 to 3.1.9 (#306) 55f66c8 Bump cli-table from 0.4.6 to 0.4.7 (#297) 69279d2 Bump config from 0.13.0 to 0.13.1 (#303) d94cdae README: add MacPorts installation instructions (#302) f4240aa Initial implementation of calendar API (#298) 3c5fbc5 provide better error messages (#300) bc45bab remove default db uri (#299) 4897f4a Bump rmp-serde from 0.15.5 to 1.0.0 (#264) 5b2e828 Bump directories from 3.0.2 to 4.0.1 (#246) 016386c Bump urlencoding from 1.3.3 to 2.1.0 (#208) a95018c goodbye warp, hello axum (#296) 3b7ed7c fix env config parsing (#295)
Merged
ellie
added a commit
that referenced
this pull request
Apr 23, 2022
89549b3 Bump uuid from 0.8.2 to 1.0.0 (#311) 831cc98 Fix typos in the docs. (#171) 7436e4f feature-flags (#328) 508d4f4 History filter (#329) 02c70de refactor (#327) a9d1ece Added docker-compose.yml (#325) b8bdd83 Bump clap from 3.1.10 to 3.1.11 (#323) 52a3d0c Bump tracing from 0.1.33 to 0.1.34 (#324) 79597b0 Bump clap_complete from 3.1.1 to 3.1.2 (#316) 5aca611 Allow for larger commands (#321) 9085485 tracing (#315) 98d70fb treat popos as ubuntu (#319) d57f549 refactor commands for better separation (#313) 24e2971 Fix SQL cache query (#318) fe05d86 Fix delete trigger (#317) 48747e3 A few minor tweaks (#314) ed4e07d Use the count cache (#312) 6e11b8e Bump clap from 3.1.9 to 3.1.10 (#309) 44e417d Bump axum from 0.5.1 to 0.5.3 (#310) b98a378 Add count trigger (#308) 7fe523a Bump sqlx from 0.5.11 to 0.5.13 (#305) c5ab2a4 Bump clap from 3.1.8 to 3.1.9 (#306) 55f66c8 Bump cli-table from 0.4.6 to 0.4.7 (#297) 69279d2 Bump config from 0.13.0 to 0.13.1 (#303) d94cdae README: add MacPorts installation instructions (#302) f4240aa Initial implementation of calendar API (#298) 3c5fbc5 provide better error messages (#300) bc45bab remove default db uri (#299) 4897f4a Bump rmp-serde from 0.15.5 to 1.0.0 (#264) 5b2e828 Bump directories from 3.0.2 to 4.0.1 (#246) 016386c Bump urlencoding from 1.3.3 to 2.1.0 (#208) a95018c goodbye warp, hello axum (#296) 3b7ed7c fix env config parsing (#295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just deployed the older version and it was falling back on the full
count. Turns out this is because it won't upcast from INT4 to INT8
automatically, and it has to be manual
At some point the underlying total should be changed to int8, but also I
highly doubt anyone will have enough shell history to fill an int4 lol