Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynssz-max tags #211

Merged
merged 9 commits into from
Feb 19, 2025
Merged

Conversation

pk910
Copy link
Contributor

@pk910 pk910 commented Feb 18, 2025

This PR adds dynssz-max tags for all fields that have a ssz-max tag.
This does not affect any of the containers right now, but is required for generating hash tree roots of containers for non-mainnet presets.

It'd help me a lot to add these annotations to the containers already.

@pk910
Copy link
Contributor Author

pk910 commented Feb 18, 2025

@mcdee ready for review, but logic wise nothing changed so far.

Copy link
Contributor

@mcdee mcdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes required, I think.

@pk910 pk910 requested a review from mcdee February 18, 2025 21:23
@mcdee mcdee merged commit b41ce95 into attestantio:master Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants