Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four new Bots added #41

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Four new Bots added #41

merged 2 commits into from
Apr 20, 2021

Conversation

mrabro
Copy link
Contributor

@mrabro mrabro commented Mar 30, 2021

These bots are link preview generators.

These bots are link preview generators.
@alanorth
Copy link
Contributor

@mrabro The TwitterBot and TelegramBot user agents would already be matched by the bot pattern on line one of COUNTER_Robots_list.json. The WhatsApp and Trello user agents may be useful though (I'll let other contributors here discuss).

@davidatmire
Copy link
Contributor

I confirm that this pull request is currently under discussion on the COUNTER robots workgroup mailing list.

Removed Telegrambot and twitterbot as bot (pattern) is already in the list.
Copy link
Contributor Author

@mrabro mrabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatsapp and Trello bot added, Twitterbot and telegrambot removed as bot(pattern) is already present.

@davidatmire
Copy link
Contributor

@mrabro

Do you know if Trello or Whatsapp are actually acting as crawlers / bots ?

We would think that these user agents are (only?) used to fetch thumbnails/previews for pages that users link in Trello or Whatsapp.
If so, we would think that there is a 1 on 1 link between the behavior of these user agents, and a human user.
We couldn't find any information about either Whatsapp or Trello actually crawling like most of the bots/crawls do that we aim to identify & isolate.

Did you have a specific use case in mind for Trello and Whatsapp when you created this pull request ?

With thanks

@mrabro
Copy link
Contributor Author

mrabro commented Apr 1, 2021

@mrabro

Do you know if Trello or Whatsapp are actually acting as crawlers / bots ?

We would think that these user agents are (only?) used to fetch thumbnails/previews for pages that users link in Trello or Whatsapp.
If so, we would think that there is a 1 on 1 link between the behavior of these user agents, and a human user.
We couldn't find any information about either Whatsapp or Trello actually crawling like most of the bots/crawls do that we aim to identify & isolate.

Did you have a specific use case in mind for Trello and Whatsapp when you created this pull request ?

With thanks

Yes, they are user agents to fetch thumbnails or preview for pages....
I was working on some private links that are supposed to be work only first time, and when any user visits the link with provided token in url, will be expired as soon as url is opened, so my client was trying to share those private links via whatsapp, and due to whatsapp bot visiting that page to generate preview, our links get expired and no more functional to the user to whom that is meant to be.

it is just like facebook/instagram, which is already present in the list of patterns (facebookexternalhit)

@mrabro mrabro closed this Apr 5, 2021
@mrabro mrabro reopened this Apr 5, 2021
@davidatmire
Copy link
Contributor

Addition of Trello and WhatsApp approved by the COUNTER robots workgroup.
Treating the PR now.

@davidatmire davidatmire merged commit 1e17a6b into atmire:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants