COUNTER_Robots_list.json: Remove unnecessary escaping of dashes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not necessary to escape dashes (-) unless they are used in a character class where they could otherwise be used to note a range. For example, in the expression "[a-z]" the dash indicates a range of characters from a to z. If you wanted to match a literal dash in a character class you would have to use "[a-z\-]", meaning a to z or a dash. As none of our uses are inside character classes, we do not need to escape them as literals. I verified this by testing Java's java.util.regex.Pattern as well as several PCRE implementations. See: https://www.freeformatter.com/java-regex-tester.html See: https://regex101.com/
davidatmire
added a commit
that referenced
this pull request
Nov 19, 2019
Updating last_changed for bots updated by #28 Adding the 3 following bots : ^Buck\/\d ^LinkAnalyser ^User-Agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not necessary to escape dashes (-) unless they are used in a character class where they could otherwise be used to note a range.
For example, in the expression "[a-z]" the dash indicates a range of characters from a to z. If you wanted to match a literal dash in a character class you would have to use "[a-z-]", meaning "a to z or a dash". As none of our uses are inside character classes, we do not need to escape them as literals.
I verified this by testing Java's java.util.regex.Pattern as well as several PCRE implementations.