Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ForeignComposite not using correct column when building where #24

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix ForeignComposite not using correct column when building where #24

merged 1 commit into from
Sep 25, 2023

Conversation

sunkan
Copy link
Contributor

@sunkan sunkan commented Sep 21, 2023

No description provided.

@jakejohns
Copy link
Contributor

I just spent hours trying to figure out what was wrong with a project I'm working on, and this appears to solve it. Can we merge and release this?

@pmjones
Copy link
Contributor

pmjones commented Sep 25, 2023

Thanks for this!

@pmjones pmjones merged commit 861e1b2 into atlasphp:1.x Sep 25, 2023
@pmjones
Copy link
Contributor

pmjones commented Sep 25, 2023

Thanks @sunkan and @jakejohns for your patience -- I just released 1.4.1 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmjones pmjones pmjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunkan @jakejohns @pmjones