Performance optimisations on stitchIntoRecord #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests some performance optimisations on stitchRecord, as per the discussion in #12. The general approach is:
I've not analysed/improved many-2-many relationships in this PR but I suspect there is possible further improvement in the case of many-2-1 and many-2-many around keying foreign records on a hash of their match fields to prevent multiple scans through the foreignRecords array. However, this would require a larger re-working on the stitching methods.