Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/#802 Array fields error in form #804

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Sep 20, 2019

Fix for #802

Make sure reference is set when creating a Multiline in form using type array.

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #804 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #804   +/-   ##
==========================================
  Coverage      76.19%   76.19%           
- Complexity      2287     2288    +1     
==========================================
  Files            119      119           
  Lines           5397     5397           
==========================================
  Hits            4112     4112           
  Misses          1285     1285
Impacted Files Coverage Δ Complexity Δ
src/Form.php 73.33% <100%> (ø) 69 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f21a42...0cdd739. Read the comment docs.

Copy link
Collaborator

@PhilippGrashoff PhilippGrashoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As someday there is another array field support planned (#752), some more has to happen here, but thats for another PR adressing #752

@acicovic
Copy link
Collaborator

acicovic commented Oct 2, 2019

@PhilippGrashoff you didn't merge this but I see no other reviewers. You think it should be reviewed by someone else before merging?

@PhilippGrashoff PhilippGrashoff merged commit 781243e into develop Oct 2, 2019
@mvorisek mvorisek deleted the fix/#802-array-field-error branch April 26, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants