Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Is Not" for TableColumn::FilterModel::TypeString #796

Conversation

funyx
Copy link
Contributor

@funyx funyx commented Aug 26, 2019

add "Is Not" option for TableColumn::FilterModel::TypeString

https://puu.sh/E9Rqy/5e2cdd5908.png

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #796 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #796      +/-   ##
=============================================
- Coverage      76.54%   76.49%   -0.05%     
- Complexity      2251     2252       +1     
=============================================
  Files            119      119              
  Lines           5337     5340       +3     
=============================================
  Hits            4085     4085              
- Misses          1252     1255       +3
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/FilterModel/TypeString.php 33.33% <0%> (-4.77%) 8 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5b7ce...322236b. Read the comment docs.

Copy link
Contributor

@skondakov skondakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good

Copy link
Contributor

@skondakov skondakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think code is good

@skondakov
Copy link
Contributor

Now it all looks good to me. Thanks!

@skondakov skondakov merged commit 73bc229 into atk4:develop Aug 27, 2019
@funyx funyx deleted the feature/add-is-not-to-tablecolumn-filtermodel-typestring branch August 27, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants