Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow URL array phpdoc types #2065

Merged
merged 10 commits into from
Jun 7, 2023
Merged

Narrow URL array phpdoc types #2065

merged 10 commits into from
Jun 7, 2023

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 6, 2023

also drop App::$page introduced in #131, it seems to be used internally only to cache the current page - reintroduced in #2096 as App::$urlBuildingIndexPage because of #2095 (comment)

@mvorisek mvorisek force-pushed the improve_url_types branch from 8a34712 to cfeb1dc Compare June 6, 2023 19:44
@mvorisek mvorisek marked this pull request as draft June 6, 2023 19:54
@mvorisek mvorisek force-pushed the improve_url_types branch from cfeb1dc to 2448c05 Compare June 6, 2023 19:54
@mvorisek mvorisek force-pushed the improve_url_types branch from 21984c9 to 8f29abc Compare June 7, 2023 12:39
@mvorisek mvorisek marked this pull request as ready for review June 7, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant