Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint LESS files using Stylelint #1948

Merged
merged 9 commits into from
Jan 6, 2023
Merged

Lint LESS files using Stylelint #1948

merged 9 commits into from
Jan 6, 2023

Conversation

mvorisek
Copy link
Member

No description provided.

mvorisek
mvorisek commented Dec 12, 2022
View reviewed changes
public/css/agileui.less
@@ -113,14 +113,14 @@
justify-content: center;
}
}
&:not(active) {
&:not(.active) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was a bug I belive

@mvorisek mvorisek force-pushed the stylelint branch 5 times, most recently from 59d10cf to 60ad5df Compare December 14, 2022 18:48
mvorisek
mvorisek commented Dec 14, 2022
View reviewed changes
public/css/agileui.less Outdated
@@ -216,7 +211,7 @@ footer.atk-footer {
width: 40%;
z-index: @rightPanelIndex;
&.atk-visible {
box-shadow: 0px 0 5px fade(@black, 20%);
box-shadow: 0 0 5px fade(@black, 20%);
Copy link
Member Author

@mvorisek mvorisek Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this css value is not passing styleling, introduced in 03f0ab2

@ibelar any idea how to fix it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try like this:
box-shadow: 0px 0px 5px fade(@black, 20%);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LESS can render it, but what should it do?

docs https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow

Copy link
Member Author

@mvorisek mvorisek Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://lesscss.org/less-preview/#eyJjb2RlIjoiQGJsYWNrOiAjMDAwO1xuXG5saWIge1xuICAgIGJveC1zaGFkb3c6IDAgMCA1cHggZmFkZShAYmxhY2ssIDIwJSk7XG59IiwiYWN0aXZlVmVyc2lvbiI6IjQuMS4zIn0= fade() seems to be a LESS function but Stylelint does not like it...

and should be safe to change to rgba https://lesscss.org/less-preview/#eyJjb2RlIjoiQGJsYWNrOiAjMDUwO1xuXG5saWIge1xuICAgIGJveC1zaGFkb3c6IDAgMCA1cHggcmdiYShAYmxhY2ssIDIwJSk7XG4gICAgYm94LXNoYWRvdzI6IDAgMCA1cHggZmFkZShAYmxhY2ssIDIwJSk7XG59IiwiYWN0aXZlVmVyc2lvbiI6IjQuMS4zIn0=

@mvorisek mvorisek force-pushed the stylelint branch 2 times, most recently from cf52e00 to 9403ad0 Compare December 22, 2022 14:43
@mvorisek mvorisek marked this pull request as ready for review January 6, 2023 19:03
@mvorisek mvorisek merged commit ef3caa2 into develop Jan 6, 2023
@mvorisek mvorisek deleted the stylelint branch January 6, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibelar ibelar ibelar left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @ibelar