Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested modal support #1765

Merged
merged 14 commits into from
Apr 23, 2022
Merged

Fix nested modal support #1765

merged 14 commits into from
Apr 23, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 8, 2022

fixes #1732
fixes #1699
and highly improves the Behat testing quality

Steps to reproduce:

  1. open debug example demos/_unit-test/crud_gh1732.php
  2. click "flag" icon on the 1st row
  3. click "edit" icon in the opened modal and notice Mustard name
  4. click outside the modal to close it (the Product modal)
  5. click outside the modal to close it (the Category modal)
  6. repeat 2. step with 2nd row
  7. repeat 3. step, notice, there is still Mustard name instead of Cola

@mvorisek mvorisek force-pushed the fix_nested_modal branch 17 times, most recently from a2bc59c to 112732d Compare April 9, 2022 11:32
@mvorisek mvorisek changed the base branch from develop to fix_nested_modal__base_for_diff April 9, 2022 17:15
@mvorisek mvorisek force-pushed the fix_nested_modal__base_for_diff branch from eeb0485 to 2b6226d Compare April 10, 2022 10:49
@mvorisek mvorisek force-pushed the fix_nested_modal branch 3 times, most recently from e3cd3e1 to a2c7779 Compare April 10, 2022 12:40
@mvorisek mvorisek changed the title Fix nested modal Fix nested modal support Apr 10, 2022
@mvorisek mvorisek force-pushed the fix_nested_modal__base_for_diff branch from 2b6226d to 197213e Compare April 10, 2022 13:00
@mvorisek mvorisek force-pushed the fix_nested_modal__base_for_diff branch from 197213e to 824b263 Compare April 10, 2022 18:21
@mvorisek mvorisek force-pushed the fix_nested_modal branch 2 times, most recently from d683896 to 7591e25 Compare April 10, 2022 19:02
@mvorisek mvorisek force-pushed the fix_nested_modal branch 6 times, most recently from 30d3397 to 56d8b55 Compare April 20, 2022 14:05
@mvorisek mvorisek force-pushed the fix_nested_modal branch 2 times, most recently from 6b80f23 to 6044ce5 Compare April 23, 2022 11:27
@mvorisek mvorisek force-pushed the fix_nested_modal branch 4 times, most recently from 6deab34 to 956fa4e Compare April 23, 2022 14:24
@mvorisek mvorisek marked this pull request as ready for review April 23, 2022 14:59
@mvorisek mvorisek merged commit b612681 into develop Apr 23, 2022
@mvorisek mvorisek deleted the fix_nested_modal branch April 23, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Cruds in multiple-layered modals behave strange Modal is rendered empty on the first open
1 participant