Fix strict types in App::getTag()

src/Persistence/Ui.php

@@ -51,6 +51,8 @@ class Ui extends \Atk4\Data\Persistence
 
     /**
      * This method contains the logic of casting generic values into user-friendly format.
+     *
+     * @return string|string[]
      */
     public function _typecastSaveField(\Atk4\Data\Field $f, $value)
     {
@@ -103,7 +105,9 @@ public function _typecastSaveField(\Atk4\Data\Field $f, $value)
                 break;
         }
 
-        return $value;
+        return is_array($value)
+            ? array_map(function ($v) { return (string) $v; }, $value)
+            : (string) $value;
     }
 
     /**

src/View.php

@@ -187,6 +187,7 @@ public function setSource(array $data, $fields = null)
     {
         $this->setModel(new Model(new Static_($data)), $fields);
         $this->model->getField($this->model->id_field)->type = null; // TODO probably unwanted
+        $this->model->getField($this->model->id_field)->required = false; // TODO probably unwanted
 
         return $this->model;
     }

tests/DemosTest.php

@@ -237,29 +237,41 @@ public function demoFilesProvider(): array
         $excludeDirs = ['_demo-data', '_includes', '_unit-test', 'special'];
         $excludeFiles = ['layout/layouts_error.php'];
 
-        // these tests require SessionTrait, more precisely session_start() which we do not support in non-HTTP testing
-        if (static::class === self::class) {
-            $excludeFiles[] = 'collection/tablefilter.php';
-            $excludeFiles[] = 'interactive/popup.php';
-        }
-
         $files = [];
-        $files[] = ['index.php'];
+        $files[] = 'index.php';
         foreach (array_diff(scandir(static::DEMOS_DIR), ['.', '..'], $excludeDirs) as $dir) {
             if (!is_dir(static::DEMOS_DIR . '/' . $dir)) {
                 continue;
             }
 
             foreach (scandir(static::DEMOS_DIR . '/' . $dir) as $f) {
-                if (substr($f, -4) !== '.php' || in_array($dir . '/' . $f, $excludeFiles, true)) {
+                $path = $dir . '/' . $f;
+                if (substr($path, -4) !== '.php' || in_array($path, $excludeFiles, true)) {
                     continue;
                 }
 
-                $files[] = [$dir . '/' . $f];
+                $files[] = $path;
             }
         }
 
-        return $files;
+        // these tests require SessionTrait, more precisely session_start() which we do not support in non-HTTP testing
+        // always move these tests to the end, so data provider # stays same as much as possible across tests for fast skip
+        $httpOnlyFiles = ['collection/tablefilter.php', 'interactive/popup.php'];
+        foreach ($files as $k => $path) {
+            if (in_array($path, $httpOnlyFiles, true)) {
+                unset($files[$k]);
+                $files[] = $path;
+            }
+        }
+        if (static::class === self::class) {
+            foreach ($files as $k => $path) {
+                if (in_array($path, $httpOnlyFiles, true)) {
+                    unset($files[$k]);
+                }
+            }
+        }
+
+        return array_map(function (string $v) { return [$v]; }, $files);
     }
 
     /**