Remove Model\ArrayAccessTrait trait #958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use hintable instead: it allows you to access/set field values as if there were properties, in reality, the properties are virtualized based on phpdoc above the model class
to use it, you need to define each property incl. the type, above your model classes, see ui demos or https://github.com/mvorisek/atk4-hintable-mirror/blob/develop/tests/Data/Model/Standard.php and https://github.com/mvorisek/atk4-hintable-mirror/blob/develop/tests/Data/HintableModelArrayTest.php
the advantage is much shorter code which supports refactoring incl. type checking, field names are refactorable using brutal magic too like
$model->fieldName()->customer_name
😉also all traversing is then as simple as
$customer->address->city
instead of$customer->ref('address')->get('city')