Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate Field properties #891

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Deduplicate Field properties #891

merged 3 commits into from
Sep 29, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Sep 29, 2021

HasOne is defining the same properties for seeding, deduplicate them. They were already out of date.

no BC break (except when Field seed properties are accessed from HasOne after init() on it was called)

@mvorisek mvorisek force-pushed the dedup_field_props branch 8 times, most recently from 151ba7a to bbf962e Compare September 29, 2021 11:11
@mvorisek mvorisek marked this pull request as ready for review September 29, 2021 11:18
@mvorisek mvorisek force-pushed the dedup_field_props branch 5 times, most recently from 8c9fcdc to 5256bf4 Compare September 29, 2021 15:10
Copy link
Collaborator

@abbadon1334 abbadon1334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit 992ac4d into develop Sep 29, 2021
@mvorisek mvorisek deleted the dedup_field_props branch September 29, 2021 17:27
@mvorisek mvorisek mentioned this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants