Add additional Join test with field actual names and prefixes #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Feb 25, 2021
| $this->assertEquals( | ||
| [ | ||
| 'user' => [ | ||
| 1 => ['id' => 1, 'first_name' => 'John 2', 'cid' => 1], |
There was a problem hiding this comment.
I belive this is wrong, as actual name should be used for low level SQL only, otherwise field name (not actual name) should be used.
This line should be:
1 => ['id' => 1, 'first_name' => 'John 2', 'contact_id' => 1],
There was a problem hiding this comment.
Not really. This is just direct dump from DB, so there will be actual names here.
There was a problem hiding this comment.
You are right, but in export and other non-low-level dumps it should not have the actual name.
There was a problem hiding this comment.
yes in import / export should not have actual names.
But as you see in Join class it still will use actual names when linking tables. See I added comment there in this PR.
I don't think we have to change that, but having additional note about that could be good.
mvorisek
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.