Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table must be specified with table key in defaults #819

Merged
merged 6 commits into from
Dec 29, 2020

Conversation

mvorisek
Copy link
Member

No description provided.

@mvorisek mvorisek marked this pull request as draft December 29, 2020 22:26
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix tests appropriately.

@mvorisek mvorisek marked this pull request as ready for review December 29, 2020 23:28
@mvorisek mvorisek force-pushed the no_str_default_table branch from 3ffad24 to 4a6df0f Compare December 29, 2020 23:31
@mvorisek mvorisek force-pushed the no_str_default_table branch 2 times, most recently from 9772945 to b2846b3 Compare December 29, 2020 23:40
@mvorisek mvorisek force-pushed the no_str_default_table branch 2 times, most recently from 83aaeab to 2fc0de3 Compare December 29, 2020 23:44
@mvorisek mvorisek force-pushed the no_str_default_table branch from 2fc0de3 to 41b11e5 Compare December 29, 2020 23:49
@mvorisek mvorisek merged commit c4eebb4 into develop Dec 29, 2020
@mvorisek mvorisek deleted the no_str_default_table branch December 29, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants