Add `Model\AggregateModel` model #817

georgehristov · 2020-12-29T11:31:34Z

extracted from atk4/report and original #677

tests/Model/Client.php

src/Model/AggregatesTrait.php

mvorisek · 2020-12-29T11:48:16Z

src/Model/Aggregate.php

+
+            // simple condition
+            if ($condition instanceof Model\Scope\Condition) {
+                $query->having(...$condition->toQueryArguments());


having is an interesting argument for Aggregate class, but we may use HAVING instead or WHERE when grouping is active in general (before we can analyse if HAVING is really needed)

Ok for now if we will integrate it for wrapping like now... But keep this unresolved in GH discussion.

not if we wrap as subquery...

Related with https://github.com/atk4/data/pull/853/files#diff-7e7810cb7d196a13e4c0b10d1c737e5ead3e3169bd82f6b4c1149dcf67d726f0R384 , I belive wrapping is the only solution, having requires group by across all columns for some DB vendors (even if grouped by some unique column)

TODO after #946 - traversing may be implemented using model wrapping

but it will require "virtualized Fields" - maybe we should always impl. different persistence fields using specific subobjects

src/Model/Aggregate.php

tests/Model/Client.php

src/Model/Aggregate.php

docs/aggregates.rst

tests/ModelAggregateTest.php

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

mvorisek · 2022-03-21T16:52:03Z

@georgehristov this PR is almost done, please let me know if you have any feedback

georgehristov requested review from mvorisek and DarkSide666 December 29, 2020 11:31

[feature] introduce Model\Aggregate

690e1ca

georgehristov force-pushed the feature/introduce-aggregate-model branch from dc3a13a to 690e1ca Compare December 29, 2020 11:41

mvorisek reviewed Dec 29, 2020

View reviewed changes

tests/Model/Client.php Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

src/Model/AggregatesTrait.php Outdated Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

src/Model/Aggregate.php Outdated Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

src/Model/Aggregate.php Outdated Show resolved Hide resolved

[update] avoid modifying existing model Client

2ee790b

mvorisek reviewed Dec 29, 2020

View reviewed changes

tests/Model/Client.php Outdated Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

src/Model/Aggregate.php Outdated Show resolved Hide resolved

georgehristov added 6 commits December 29, 2020 13:58

[update] move setup of properties to constructor

4a9f37c

[update] add docs

d566c62

[update] use strong argument typing

de06f03

[update] rename properties to intuitive names

ae45471

[update] phpdoc types

3dd1ab0

[update] allow to unset Model::$id_field

5cb2bf8

mvorisek reviewed Dec 29, 2020

View reviewed changes

src/Model/Aggregate.php Outdated Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

src/Model/Aggregate.php Outdated Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

src/Model/Aggregate.php Outdated Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

docs/aggregates.rst Outdated Show resolved Hide resolved

mvorisek reviewed Dec 29, 2020

View reviewed changes

tests/ModelAggregateTest.php Outdated Show resolved Hide resolved

georgehristov added 3 commits December 29, 2020 14:47

[update] use array_merge

68d32d3

[update] arguments and return types

8c69320

[update] tests

47fc81d

mvorisek reviewed Dec 29, 2020

View reviewed changes

tests/ModelAggregateTest.php Outdated Show resolved Hide resolved

georgehristov and others added 3 commits December 29, 2020 15:05

[update] docs

adb57dc

[update] add return type for Invoice

b6b0852

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

[fix] phpstan issues

a974658

Merge branch 'develop' into feature/introduce-aggregate-model

25c92cb

mvorisek force-pushed the feature/introduce-aggregate-model branch 2 times, most recently from 30570d4 to 9d647a2 Compare March 14, 2022 16:09

adjust to latest develop

3db6a8a

mvorisek force-pushed the feature/introduce-aggregate-model branch from 9d647a2 to 3db6a8a Compare March 14, 2022 16:11

Merge branch 'develop' into feature/introduce-aggregate-model

9349c88

mvorisek force-pushed the feature/introduce-aggregate-model branch from df01c10 to a40350f Compare April 15, 2022 18:11

mvorisek added 3 commits April 15, 2022 20:58

adjust to latest develop

e2cd2e2

simplify

8ae2036

fix cloned field - we should either disallow refs or wrap twice

9c9fa6f

mvorisek force-pushed the feature/introduce-aggregate-model branch from a40350f to a7d86d9 Compare April 15, 2022 19:00

mvorisek added 4 commits April 15, 2022 21:20

compact assertSameExportUnordered assertions

2da2f6a

fix array merge

07d1838

fix count query

5d8ee39

no false for initQueryFields

431da2e

mvorisek force-pushed the feature/introduce-aggregate-model branch from a7d86d9 to 431da2e Compare April 15, 2022 19:25

mvorisek added 2 commits April 15, 2022 21:25

fix cloned field - we should either disallow refs or wrap twice

1a821a8

fix ii - do not clone field

8e8bfd5

mvorisek force-pushed the feature/introduce-aggregate-model branch from 431da2e to 5d8ee39 Compare April 15, 2022 19:31

fix unaggregated fields for pgsql

a46433d

mvorisek force-pushed the feature/introduce-aggregate-model branch from 2f27f5d to a46433d Compare April 15, 2022 20:29

compact test code

95af333

mvorisek force-pushed the feature/introduce-aggregate-model branch from 8a28632 to 95af333 Compare April 15, 2022 21:02

mvorisek added 2 commits April 16, 2022 00:44

rename hook const

5520638

fix cs

c6c8921

mvorisek force-pushed the feature/introduce-aggregate-model branch from 257ba85 to c6c8921 Compare April 15, 2022 22:54

mvorisek added the MAJOR label Apr 15, 2022

mvorisek merged commit 8b47b2d into develop Apr 15, 2022

mvorisek deleted the feature/introduce-aggregate-model branch April 15, 2022 23:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Model\AggregateModel` model #817

Add `Model\AggregateModel` model #817

georgehristov commented Dec 29, 2020 •

edited by mvorisek

Loading

mvorisek Dec 29, 2020

mvorisek Dec 29, 2020 •

edited

Loading

mvorisek Dec 30, 2020

mvorisek May 10, 2021

mvorisek Jan 6, 2022 •

edited

Loading

mvorisek commented Mar 21, 2022

Add Model\AggregateModel model #817

Add Model\AggregateModel model #817

Conversation

georgehristov commented Dec 29, 2020 • edited by mvorisek Loading

mvorisek Dec 29, 2020

Choose a reason for hiding this comment

mvorisek Dec 29, 2020 • edited Loading

Choose a reason for hiding this comment

mvorisek Dec 30, 2020

Choose a reason for hiding this comment

mvorisek May 10, 2021

Choose a reason for hiding this comment

mvorisek Jan 6, 2022 • edited Loading

Choose a reason for hiding this comment

mvorisek commented Mar 21, 2022

Add `Model\AggregateModel` model #817

Add `Model\AggregateModel` model #817

georgehristov commented Dec 29, 2020 •

edited by mvorisek

Loading

mvorisek Dec 29, 2020 •

edited

Loading

mvorisek Jan 6, 2022 •

edited

Loading