Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No explicit $table param in Array & Csv persistences #656

Merged
merged 2 commits into from
Apr 19, 2021
Merged

No explicit $table param in Array & Csv persistences #656

merged 2 commits into from
Apr 19, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jul 15, 2020 •
edited
Loading

should have no impact on the end-user, internal cleanup only

@mvorisek mvorisek changed the title No explicit table param No explicit $table param in Array/Csv Persistence Jul 15, 2020
@mvorisek mvorisek force-pushed the no_explicit_table_param branch from 9b24445 to 8fce95a Compare July 15, 2020 12:24
@mvorisek mvorisek force-pushed the no_explicit_table_param branch 2 times, most recently from e3966ca to 80395d4 Compare August 26, 2020 19:04
@mvorisek mvorisek force-pushed the no_explicit_table_param branch 4 times, most recently from 525ab5e to ce8b270 Compare April 19, 2021 13:04
@mvorisek mvorisek changed the title No explicit $table param in Array/Csv Persistence No explicit $table param in Array & Csv persistences Apr 19, 2021
@mvorisek mvorisek marked this pull request as ready for review April 19, 2021 13:05
@mvorisek mvorisek removed the BC-break label Apr 19, 2021
@mvorisek mvorisek force-pushed the no_explicit_table_param branch from ce8b270 to e58a7c5 Compare April 19, 2021 13:07
@mvorisek mvorisek force-pushed the no_explicit_table_param branch from e58a7c5 to 4c448d1 Compare April 19, 2021 13:08
@mvorisek mvorisek added the RTM label Apr 19, 2021
DarkSide666
DarkSide666 approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit 34548fe into develop Apr 19, 2021
@mvorisek mvorisek deleted the no_explicit_table_param branch April 19, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@georgehristov georgehristov Awaiting requested review from georgehristov

Assignees
No one assigned
Labels
Cleanup Consistency RTM
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666