Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert if reference type is the same by default #1091

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Feb 9, 2023

marking as BC-break as Reference::checkTheirType needs to be set manually to false if the DBAL type mismatch is intentional

in 99% cases, the exception is right and you want to fix your code

@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from c1d3285 to e9fa739 Compare February 9, 2023 13:37
@mvorisek mvorisek changed the title Assert if reference type is the same Assert if reference type is the same by default Feb 9, 2023
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from e9fa739 to 9ec3707 Compare February 9, 2023 13:50
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from 9ec3707 to 65ed644 Compare February 9, 2023 19:42
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from 65ed644 to af1ea76 Compare February 9, 2023 19:50
@mvorisek mvorisek marked this pull request as ready for review February 9, 2023 20:25
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from c01e8cd to ac545e8 Compare February 9, 2023 20:51
@mvorisek mvorisek merged commit 856f742 into develop Feb 9, 2023
@mvorisek mvorisek deleted the strict_ref_type_chack branch February 9, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant